These pages are for concrete suggestions of small improvements that could be done in Squeak. Use the following convention: DONE when you propose a fix, INCORPORATED to say that this is incorporated into the Squeak World Tour image.
Please be concrete so that we can fix them.
- Creating a SystemOrganizer using new creates a badly initialized instance.
SystemOrganizer>>new
^self error: 'you should not use new to create instances of me but defautList'
SystemOrganizer>>defaultList: aSortedCollection
"Answer an instance of me with initial elements from the argument,
aSortedCollection."
^ self basicNew setDefaultList: aSortedCollection
- SystemOrganizer is missing a correct class initialize method. When there is no category we should have no category message and not 'no messages'. I made it and will clean my changset and add it here. (I introduced class instance variable instead of ClassVariables because else we cannot have a separate default message for class and system categories.) Stephane Ducasse
- Could we get rid of all the _ and replace them by :=
- FileDirector contains mac specific method (2) that should be moved into MacFileDrector so easy
- a real pretty printer with a visitor and the possibility to change colors without having to recompile a method.
- Browser>>openBrowser should use the defautlBrowserTitle and not having hardcoded BROWSER everywhere.
Browser>>openBrowser
"Create and schedule a BrowserView with the default system label. The
view consists of five subviews, starting with the list view of system
categories of SystemOrganization. The initial text view part is empty."
|br|
br := (self new openEditString: nil).
self openBrowserView: br
label: br defaultBrowserTitle
- The global variable SystemOrganization should be removed.
- Bad super send in Class>fileOutOn:moveSource:toFile:initializing:. This indicates some bad design that should be refactored.
- command: to put html command in stream has nothing to do in PositionableStream !
- StandardFileStream>>compressFile automatically pops up a progress bar.
- In Class>>removeFromSystem:, it would be interesting (for module and unload of classes) to introduce a hook method that classes may override if needed. This would avoid to let the classdeveloper to have the responsibility to specialize removeFromSystem and to invoke super.
Fill in